Re: [PATCH v3 char-misc 1/1] Drivers: hv: vmbus: Implement Direct Mode for stimer0

[Greg KH]

On Sun, Jan 28, 2018 at 09:06:48PM +0000, Michael Kelley (EOSG) wrote:
> From: Michael Kelley <mikelley@xxxxxxxxxxxxx>
> 
> The 2016 version of Hyper-V offers the option to operate the guest VM
> per-vcpu stimer's in Direct Mode, which means the timer interupts on its
> own vector rather than queueing a VMbus message. Direct Mode reduces
> timer processing overhead in both the hypervisor and the guest, and
> avoids having timer interrupts pollute the VMbus interrupt stream for
> the synthetic NIC and storage.  This patch enables Direct Mode by
> default on stimer0 when running on a version of Hyper-V that supports it,
> with a hv_vmbus module parameter for disabling Direct Mode and reverting
> to the old behavior.

You didn't change the text here as there is no more module parameter :(

> --- a/drivers/hv/hv.c
> +++ b/drivers/hv/hv.c
> @@ -27,8 +27,9 @@
>  #include <linux/vmalloc.h>
>  #include <linux/hyperv.h>
>  #include <linux/version.h>
> -#include <linux/interrupt.h>
> +#include <linux/random.h>
>  #include <linux/clockchips.h>
> +#include <linux/module.h>

Still need this .h file?

thanks,

greg k-h