Re: [PATCH v19 03/10] video: backlight: Add of_find_backlight helper in backlight.c

[Lee Jones]

On Fri, 26 Jan 2018, Randy Dunlap wrote:

> On 01/26/2018 01:48 AM, Lee Jones wrote:
> > On Wed, 24 Jan 2018, Meghana Madhyastha wrote:
> > 
> >> Add of_find_backlight, a helper function which is a generic version
> >> of tinydrm_of_find_backlight that can be used by other drivers to avoid
> >> repetition of code and simplify things.
> >>
> >> Acked-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> >> Reviewed-by: Noralf TrÃnnes <noralf@xxxxxxxxxxx>
> >> Reviewed-by: Sean Paul<seanpaul@xxxxxxxxxxxx>
> >> Signed-off-by: Meghana Madhyastha <meghana.madhyastha@xxxxxxxxx>
> > 
> > Nit: These should be in chronological order.
> 
> Where does that tidbit of information come from?
> I have never heard or read that.

Not sure it is documented anywhere.  It appeared to be the widely
used, most sensible approach, so I adopted it a few years ago.

This method provides us with information which would otherwise be
absent; including description of the patch submission/acceptance path
and an idea of who did what, when.

For example:

Original Author sign-off
Original Co-author sign-off
[Additional contributions: rebase, API changes, fix-ups]
Re-worker's sign-off
Tester's tested-by
Reviewer's acked-by/reviewed-by
Level-2 Maintainer sign-off
Level-1 Maintainer sign-off

Are you aware of a more functional/practical/useful method?

-- 
Lee Jones
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog