Re: [PATCH v2 20/43] drm/bridge: analogix_dp: Extend hpd check time to 100ms

[Sean Paul]

On Fri, Jan 26, 2018 at 02:16:47PM +0100, Thierry Escande wrote:
> From: Lin Huang <hl@xxxxxxxxxxxxxx>
> 
> There was a 1ms delay to detect the hpd signal, which is too short to
> detect a short pulse. This patch extends this delay to 100ms.

The commit message doesn't align with the code here. The code below matches the
code in the CrOS tree, so let's just fix up the commit message.


> 
> Cc: StÃphane Marchesin <marcheu@xxxxxxxxxxxx>
> Cc: åå ç <wzz@xxxxxxxxxxxxxx>
> Signed-off-by: Lin Huang <hl@xxxxxxxxxxxxxx>
> Signed-off-by: Sean Paul <seanpaul@xxxxxxxxxxxx>
> Signed-off-by: Thierry Escande <thierry.escande@xxxxxxxxxxxxx>
> Reviewed-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
> ---
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index fa4ef28e286f..9df92dc54dbe 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -76,7 +76,7 @@ static int analogix_dp_detect_hpd(struct analogix_dp_device *dp)
>  			return 0;
>  
>  		timeout_loop++;
> -		usleep_range(10, 11);
> +		usleep_range(1000, 1100);
>  	}
>  
>  	/*
> -- 
> 2.14.1
> 

-- 
Sean Paul, Software Engineer, Google / Chromium OS