Re: [GIT PULL] inode->i_version rework for v4.16

From: Theodore Ts'o
Date: Tue Jan 30 2018 - 11:08:50 EST


On Tue, Jan 30, 2018 at 07:05:48AM -0500, Jeff Layton wrote:
>
> I want to make sure I understand what's actually broken here thoug. Is
> it only broken when the two values are more than 2**63 apart, or is
> there something else more fundamentally wrong here?

The other problem is that returning a s64 (or a u64) is extremely
inefficient on a 32-bit platform. So in general, it's better to avoid
returning a 64-bit type unless it's really necessary....

- Ted