Re: [PATCH v2 3/3] KVM: VMX: make MSR bitmaps per-VCPU

From: David Woodhouse
Date: Tue Jan 30 2018 - 11:30:09 EST




On Tue, 2018-01-30 at 17:23 +0100, Radim KrÄmÃÅ wrote:
>
> The physical address of the nested msr_bitmap is never loaded into vmcs.
>
> The resolution you provided had extra hunk in prepare_vmcs02_full():
>
> +ÂÂÂÂÂÂÂvmcs_write64(MSR_BITMAP, __pa(vmx->nested.vmcs02.msr_bitmap));
>
> I have queued that as:
>
> +ÂÂÂÂÂÂÂif (cpu_has_vmx_msr_bitmap())
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂvmcs_write64(MSR_BITMAP, __pa(vmx->nested.vmcs02.msr_bitmap));
>
> but it should be a part of the patch or a followup fix.
>
> Is the branch already merged into PTI?

No, we've never seen a 4.14-based branch that could be merged. I made
one myself for the moment but assumed there would be one from Paulo
that was then pulled into both tip/x86/pti and the kvm.git tree.

Attachment: smime.p7s
Description: S/MIME cryptographic signature