Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform
From: Andy Shevchenko
Date: Tue Jan 30 2018 - 11:48:42 EST
On Tue, Jan 30, 2018 at 2:07 PM, Baolin Wang <baolin.wang@xxxxxxxxxx> wrote:
> The Spreadtrum SC9860 platform GPIO controller contains 16 groups and
> each group contains 16 GPIOs. Each GPIO can set input/output and has
> the interrupt capability.
> +config GPIO_SPRD
> + bool "Spreadtrum GPIO support"
Either you have to put tristate here, or remove all redundant
module_*() and MODULE_*() macros.
Other than that looks fine to me, FWIW:
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
--
With Best Regards,
Andy Shevchenko