Re: [PATCH v3 3/4] KVM: VMX: Emulate MSR_IA32_ARCH_CAPABILITIES

[Paolo Bonzini]

On 29/01/2018 19:25, KarimAllah Ahmed wrote:
>>> +ÂÂÂ case MSR_IA32_ARCH_CAPABILITIES:
>>> +ÂÂÂÂÂÂÂ if (!msr_info->host_initiated)
>>> +ÂÂÂÂÂÂÂÂÂÂÂ return 1;
>>> +ÂÂÂÂÂÂÂ vmx->arch_capabilities = data;
>>> +ÂÂÂÂÂÂÂ break;
>>
>> arch capabilities is read only. You don't need the set_msr handling
>> for this.
> 
> This is only for host driven writes. This would allow QEMU/whatever to
> override the default value (i.e. the value from the hardware).

Agreed.

Reviewed-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>