Re: 4.15: WARNING: CPU: 3 PID: 258 at kernel/irq/chip.c:244 __irq_startup+0x80/0x100

From: Thomas Gleixner
Date: Wed Jan 31 2018 - 02:58:40 EST


On Wed, 31 Jan 2018, Meelis Roos wrote:
> > > Your supply of vintage hardware is amazing.
>
> :-)
>
> > Does the patch below fix the issue for you?
>
> CC kernel/irq/autoprobe.o
> kernel/irq/autoprobe.c: In function ʽprobe_irq_onʼ:
> kernel/irq/autoprobe.c:74:8: error: void value not ignored as it ought to be
> if (irq_activate_and_startup(desc, IRQ_NORESEND))
> ^~~~~~~~~~~~~~~~~~~~~~~~

Duh.

> Just
> irq_activate_and_startup(desc, IRQ_NORESEND);

Indeed.

> cures the warning and at least the first bootup was working otherwise
> too.

I'll do a proper fix and queue it so your museum is kept alive.

Thanks,

tglx