Re: [PATCH] Rename make inode_cmp_iversion{+raw} to inode_eq_iversion{+raw}
From: Matthew Wilcox
Date: Wed Jan 31 2018 - 16:55:15 EST
On Wed, Jan 31, 2018 at 09:43:09PM +0100, Goffredo Baroncelli wrote:
> The function inode_cmp_iversion{+raw} is counter-intuitive, because it
> returns true when the counters are different and false when these are equal.
>
> Rename it to inode_eq_iversion{+raw}, which will returns true when
> the counters are equal and false otherwise.
A lot of places use !inode_eq_iversion(). I think we should have both
inode_eq_iversion() and inode_ne_iversion().
Also, we have 'inode' in the name, why keep the 'i'? inode_eq_version()
and inode_ne_version() are shorter. We could even go so far as
iversion_eq() and iversion_ne() if keeping 'iversion' in the string
is important.