Re: [PATCH 7/8] Input: mms114 - add SPDX identifier

From: Dmitry Torokhov
Date: Wed Jan 31 2018 - 17:53:18 EST


On Wed, Jan 31, 2018 at 08:31:38AM +0100, Marcus Folkesson wrote:
> Hi Andy,
>
> On Wed, Jan 31, 2018 at 03:07:26PM +0900, Andi Shyti wrote:
> > Hi Dmitry,
> >
> > > > -/*
> > > > - * Copyright (C) 2012 Samsung Electronics Co.Ltd
> > > > - * Author: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>
> > > > - *
> > > > - * This program is free software; you can redistribute it and/or modify
> > > > - * it under the terms of the GNU General Public License version 2 as
> > > > - * published by the Free Software Foundation.
> > > > - */
> > > > +// SPDX-License-Identifier: GPL-2.0
> > > > +// Samsung S6SY761 Touchscreen device driver
> >
> > I'm very sorry, but my distrcation will kill me one day.
>
> More coffee or sleep - your choice ;-)
>
> >
> > Is it possible to revert this patch or do you want me to send a
> > fix?
>
> When you are on it;
>
> Change
> MODULE_LICENSE("GPL");
>
> to
> MODULE_LICENSE("GPL v2");
> To match the former license text and SPDX-identifier.
>
> See include/linux/module.h:
> * "GPL" [GNU Public License v2 or later]
> * "GPL v2" [GNU Public License v2]

OK, I dropped the patch, please resend the correct version.

Thanks.

--
Dmitry