Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

[Baolin Wang]

On 31 January 2018 at 22:23, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
> On Wed, Jan 31, 2018 at 4:01 AM, Baolin Wang <baolin.wang@xxxxxxxxxx> wrote:
>> On 31 January 2018 at 00:48, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
>>> On Tue, Jan 30, 2018 at 2:07 PM, Baolin Wang <baolin.wang@xxxxxxxxxx> wrote:
>>>> The Spreadtrum SC9860 platform GPIO controller contains 16 groups and
>>>> each group contains 16 GPIOs. Each GPIO can set input/output and has
>>>> the interrupt capability.
>>>
>>>> +config GPIO_SPRD
>>>
>>>> +       bool "Spreadtrum GPIO support"
>>>
>>> Either you have to put tristate here, or remove all redundant
>>> module_*() and MODULE_*() macros.
>>
>> I will remove module_*() and MODULE_*() macros in next version. Thanks
>> for your comments.
>
> In that case you need to explain why driver can't be module. (And
> don't forget to replace module.h with init.h).

After more investigation, I found most GPIO dependencies can be
deferred to probe. So I will change the GPIO driver to module level
and change bool to tristate in next version.

-- 
Baolin.wang
Best Regards