[PATCH] firmware: dmi_scan: avoid printing error on non-efi systems

From: Martin HundebÃll
Date: Thu Feb 01 2018 - 03:08:30 EST


dmi_init() rightfully checks if dmi is available at all, and errors out
if not. This leads to harmless errors being printed during boot on
non-efi systems, even when these are booted quietly.

Avoid this error-print by returning directly from dmi_init() if dmi
isn't available, instead of jumping to the err-label.

Signed-off-by: Martin HundebÃll <mnhu@xxxxxxxxx>
---
drivers/firmware/dmi_scan.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
index 783041964439..86c5e0625a08 100644
--- a/drivers/firmware/dmi_scan.c
+++ b/drivers/firmware/dmi_scan.c
@@ -715,10 +715,8 @@ static int __init dmi_init(void)
u8 *dmi_table;
int ret = -ENOMEM;

- if (!dmi_available) {
- ret = -ENODATA;
- goto err;
- }
+ if (!dmi_available)
+ return -ENODATA;

/*
* Set up dmi directory at /sys/firmware/dmi. This entry should stay
--
2.16.1