Re: [PATCH] ASoC: codecs: Add support for AK5558 ADC driver

[Daniel Baluta]

Hi Fabio, Andy,

Thanks a lot for your comments. I will address them and send v2.

Few comments inline.

On Mi, 2018-01-31 at 18:12 +0200, Andy Shevchenko wrote:
> On Wed, Jan 31, 2018 at 2:57 PM, Daniel Baluta <daniel.baluta@xxxxxxx> wrote:
> > 
> > AK5558 is a 32-bit, 768 kHZ sampling, differential input ADC
> > for digital audio systems.
> > 
> > Signed-off-by: Junichi Wakasugi <wakasugi.jb@xxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Mihai Serban <mihai.serban@xxxxxxx>
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@xxxxxxx>
> > Signed-off-by: Daniel Baluta <daniel.baluta@xxxxxxx>
> 4 authors of the code?!

The code has a very long history. I will add under each SoB the specific
contribution.

Mihai got the code fromÂJunichi and reworked it for 4.9. Then Shengjiu and
me added variousÂfeatures and cleanups.

According to DCO [1] all SoB are valid and required.


> > +MODULE_AUTHOR("Junichi Wakasugi <wakasugi.jb@xxxxxxxxxxxxxxxxxxxx>");
> > +MODULE_AUTHOR("Mihai Serban <mihai.serban@xxxxxxx>");
> 4 SoBs, 2 Authors. Please, fix accordingly.

Here I would prefer to list Junichi and Mihai because they were the main contributors.
Any other suggestion?

thanks,
Daniel.

[1] [1]Âhttps://developercertificate.org/