Re: [PATCH] xfs: Add missing braces around xfs_scrub_agfl_info initializer

[Arnd Bergmann]

On Thu, Feb 1, 2018 at 11:23 AM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> With gcc-4.1.2:
>
>     fs/xfs/scrub/agheader.c: In function âxfs_scrub_agflâ:
>     fs/xfs/scrub/agheader.c:770: warning: missing braces around initializer
>     fs/xfs/scrub/agheader.c:770: warning: (near initialization for âsai.oinfoâ)
>
> The first member of struct xfs_scrub_agfl_info is no longer an integral
> type, but a struct.  Add the missing curly braces to fix this.

I suspect gcc-4.5 is affected as well, but not 4.6+

> --- a/fs/xfs/scrub/agheader.c
> +++ b/fs/xfs/scrub/agheader.c
> @@ -767,7 +767,7 @@ int
>  xfs_scrub_agfl(
>         struct xfs_scrub_context        *sc)
>  {
> -       struct xfs_scrub_agfl_info      sai = { 0 };
> +       struct xfs_scrub_agfl_info      sai = { { 0 } };
>         struct xfs_agf                  *agf;

Looks ok to me, but

        struct xfs_scrub_agfl_info      sai = { };

might be slightly better in case the first member changes again.

     Arnd