Re: [PATCHv1] dt-bindings: misc: add Intel Stratix10 service layer binding

[Richard Gong]

On 01/30/2018 10:57 AM, Rob Herring wrote:
> On Tue, Jan 23, 2018 at 01:25:02PM -0600, richard.gong@xxxxxxxxxxxxxxx wrote:
> > From: Richard Gong <richard.gong@xxxxxxxxx>
> >
> > Add a device tree binding for the Intel Stratix10 service layer driver
> >
> > Signed-off-by: Richard Gong <richard.gong@xxxxxxxxx>
> > ---
> >   .../devicetree/bindings/misc/intel-service.txt     | 56 ++++++++++++++++++++++
> >   1 file changed, 56 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/misc/intel-service.txt
> >
> > diff --git a/Documentation/devicetree/bindings/misc/intel-service.txt b/Documentation/devicetree/bindings/misc/intel-service.txt
> > new file mode 100644
> > index 0000000..254e4a1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/misc/intel-service.txt
> > @@ -0,0 +1,56 @@
> > +Intel Service Layer Driver for Stratix10 SoC
> > +============================================
> > +Intel Stratix10 SoC is composed of a 64 bit quad-core ARM Cortex A53 hard
> > +processor system (HPS) and Secure Device Manager (SDM). When the FPGA is
> > +configured from HPS, there needs to be a way for HPS to notify SDM the
> > +location and size of the configuration data. Then SDM will get the
> > +configuration data from that location and perform the FPGA configuration.
> > +
> > +To meet the whole system security needs and support virtual machine requesting
> > +communication with SDM, only the secure world of software (EL3, Exception
> > +Layer 3) can interface with SDM. All software entities running on other
> > +exception layers must channel through the EL3 software whenever it needs
> > +service from SDM.
> > +
> > +Intel Stratix10 service layer driver, running at privileged exception level
> > +(EL1, Exception Layer 1), interfaces with the service providers and provides
> > +the services for FPGA configuration, QSPI, Crypto and warm reset. Service layer
> > +driver also manages secure monitor call (SMC) to communicate with secure monitor
> > +code running in EL3.
> > +
> > +Required properties:
> > +--------------------
> > +The following are the mandatory properties:
> > +
> > +- compatible:
> > +		"intc,svc-1.0"
> > +- method:
> > +		smc or hvc
> > +			smc - Secure Monitor Call
> > +			hvc - Hypervisor Call
> Do you really need to support hvc or you are just copying and pasting
> from other implementations?
Thanks for the review.
Yes, We need to support hvc.
> > +- memory-region:
> > +		phandle to the reserved memory node. See
> > +		Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt
> > +		for details
> Please also put the svc node under the /firmware node and state that in
> the binding.
Sure, I will fix that in the next version.

Regards,
Richard
> > +
> > +Example:
> > +--------
> > +
> > +	reserved-memory {
> > +                #address-cells = <2>;
> > +                #size-cells = <2>;
> > +                ranges;
> > +
> > +                service_reserved: svcbuffer@0 {
> > +                        compatible = "shared-dma-pool";
> > +                        reg = <0x0 0x0 0x0 0x1000000>;
> > +                        alignment = <0x1000>;
> > +                        no-map;
> > +                };
> > +        };
> > +
> > +	svc {
> > +		compatible = "intc,svc-1.0";
> > +		method = "smc";
> > +		memory-region = <&service_reserved>
> > +	};
> > --
> > 2.7.4