Re: [PATCH] of: cache phandle nodes to decrease cost of of_find_node_by_phandle()

From: Chintan Pandya
Date: Fri Feb 02 2018 - 01:00:03 EST




On 2/2/2018 12:40 AM, Frank Rowand wrote:
On 02/01/18 02:31, Chintan Pandya wrote:

Anyways, will fix this locally and share test results.

Thanks, I look forward to the results.


Set up for this time was slightly different. So, taken all the numbers again.

Boot to shell time (in ms): Experiment 2
[1] BaseÂÂÂÂÂÂÂÂÂÂÂ : 14.843805 14.784842 14.842338
[2] 64 sized fixed cacheÂÂÂ : 14.189292 14.200003 14.266711
[3] Dynamic freeable cacheÂÂÂ : 14.112412 14.064772 14.036052

So, [3] (this patch) looks to be improving 750ms (on avg from base build).


Is this with the many debug options enabled? If so, can you repeat with
a normal configuration?

Could you share me the point of doing this experiment in perf mode ? I don't have a set up for taking these numbers in perf mode. For that, I need to ask some other team and round trip follow ups. In my set up, I rely on serial console logging which gets disabled in perf mode.


Thanks,

Frank


Chintan
--
Qualcom India Private Limited, on behalf of Qualcomm Innovation Center,
Inc. is a member of the Code Aurora Forum, a Linux Foundation
Collaborative Project