Re: clang warning: implicit conversion in intel_ddi.c:1481

[Jani Nikula]

On Thu, 01 Feb 2018, Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> wrote:
> Hi Greg,
>
> On Thu, 1 Feb 2018, Greg KH wrote:
>
>> On Thu, Feb 01, 2018 at 06:33:30PM +0100, Ozan Alpay wrote:
>> > Dear Rodrigo Vivi, Ville SyrjÃlÃ,
>> > 
>> > My name is Ozan Alpay, and I am a student mentored by Lukas Bulwahn. We 
>> > intend to use static analysis tools on the kernel source to identify, 
>> > analyze and report issues. As a very first step, we are looking into 
>> > clang compiler warnings and will then move to more sophisticated tools. 
>> >
>> > [...]
>> >
>> > Linux 4.15 is shipped with this clang warning, but we don't see the 
>> > crucial need to provide a backport commit to the stable branch for 4.15. 
>> > We just wanted to inform you about our analysis of this clang warning. 
>> > Ultimately the final call if you would like to address this clang warning 
>> > in 4.15 is yours.
>> 
>> Note, I have not taken "clang warning fixes" for stable kernel updates
>> in the past, and I doubt I will in the future, unless the tree "builds
>> clean" with clang.  If it eventually gets there, then yes, I will do
>> that.
>> 
>> Note, if you are going to email this out to everyone who fixes a warning
>> message, you might want to reconsider it.  That's going to be a lot of
>> work, and for people who have already fixed an issue, it's kind of
>> pointless to just remind them of work they have done in the past, right?
>> 
>> What is the goal of these types of emails?
>> 
>
> We are interested in providing useful information on potential bugs or bug 
> patterns that we get from static analysis tools, after we pre-assess them 
> and manually select them to send to the review process of the patch 
> submission.
>
> For me, the clang warnings were an easy starting point for a student to 
> set up and look at, compared to much more sophisticated tools, such as 
> coccinelle, sparse or new tools for the kernel development, such as CMBC 
> or facebook's Infer.
>
> Once we really understand which tools are useful and which information can 
> be quickly pre-assessed and sent out in a useful way without just creating 
> more noise in the discussion, I would have contacted the 0-day 
> infrastructure team or the kernelci.org team to continue the discussion 
> how to include our first setup into a proper semi-automated service.
>
> Using the clang warnings, I wanted to explore how this would even 
> potentially work.
>
> Considering clang, of course, currently, we cannot compile the whole 
> kernel with all possible kernel configurations with clang, but I believe 
> Nick Desaulniers, Matthias Kaehlcke and others are already working on 
> that and are getting close to this goal. Hence, assuming they will be 
> successful soon, I wanted to explore the next step of using static 
> analysis tools around the clang/LLVM compiler.
>
> Actually, v4.15 builds almost "cleanly" with clang: For defconfig, there 
> are only two clang compiler warnings and the one that we looked into 
> deeper here is already resolved in linux-next, so chances are actually 
> high that we might get to this "builds clean" soon-ish, at least for 
> defconfig.
>
> Concerning clang warnings and how to progress towards that goal of 
> building cleanly, my strategy is to identify when new clang compiler
> warnings are introduced and just point these warnings out as code smells 
> during the review discussion before they are merged into the 
> first maintainer tree. If we manually inspect these clang warnings
> to make sure that they are genuine code smells of some "imprecise 
> implementation" before we send them to the mailing list, I would hope that 
> they are of some value for the developer in the submission process and 
> he/she could address the warning in a patch v2 while he/she is reacting to 
> the other review comments from the human reviewers.
>
> At best, I always considered them as useful information during the review 
> process, but I certainly DO NOT want to start patching the kernel due to 
> clang warnings. The chances/risk that we just break more due to naively 
> fixing warnings without proper understanding is much higher than the  
> benefit of actually improving the situation. If I recall correctly, I 
> think this is also one of the lessons learned from motivating newcomers 
> to address warnings in previous kernel newbies activities.
>
> Greg, do you think it is worthwhile to invest some effort to move 
> towards the goal "kernel builds cleanly with clang"?
> Would you agree that providing information during the patch review is a 
> good way to move forward to this goal if we find a suitable manner to 
> provide this feedback quickly and cleanly at this very early stage of 
> development?
>
> If not, we will immediately stop to move in this direction and this is the 
> first and last email that you have seen of this kind, and we will have to 
> come up with better/other ideas around work on the Linux kernel.
>
> If so, we will continue in the direction sketched above, and I think I 
> just have to point out and apologize for the two obvious things that we 
> did wrong in this specific case here:
>
>   - We noticed that there were further changes in linux-next, but we
>     thought that our investigation on v4.15 was valuable nevertheless
>     for the developers that had touched the source code that we looked at,
>     although, there is nothing to be done if commits from linux-next are
>     merged into Linus' tree soon. Taking your response, we have clearly 
>     been WRONG here, overestimating our contribution versus the noise 
>     ratio that we contribute to.
>   
>   - We looked at a clang warning, for which we could only provide the 
>     information on this clang warning at this very late stage, i.e., when
>     the commit under investigation has already been merged and the kernel 
>     was released. So pointing out shortcoming of that kind seems to have 
>     no value, as you, Greg, would not backport commits to stable anyway.
>
> This has been both errors on my side as a mentor. After my student
> has started this week and has worked hard for a week learning a lot about 
> Linux kernel development and all the tools around it, I did not want to 
> discourage him and say that the goal set at the beginning of the week to 
> identify and report a code smell on one commit on the mailing list has 
> not been achieved as for the reasons above. Instead, we decided to send it 
> out and were interested in the general reception of our work of this first 
> week.
>
> I apologize for that and hope we can leave the specific reported issue now 
> just rest in peace.
>
> This experiment shows that I still need to improve my understanding how 
> to contribute properly to the kernel development. At least to me, the  
> policy on clang warnings was not clear; and I have learned this now in 
> this more indirect way.
>
> We only sent out this one email to see if clang warnings are of interest 
> at all, and we are glad that you came back to us so quickly with feedback.
>
> Greg, if you can continue to be a sparing partner and point out when 
> we are moving in the wrong direction, we will try our best to understand
> how we can contribute to turn results from bug finders and static analysis 
> tools with the manual pre-assessment we can do into valuable contributions 
> on the mailing list and the linux kernel development.
>
> We certainly do not intend to spam the mailing list with reports of 
> findings nobody cares about.

Being brutally honest, please write shorter reports and shorter emails
to the lists.

The static analysis reports are welcome, but only when 1) we didn't
already fix it in linux-next, or 2) it reveals an actual bug, not just a
warning, warranting a backport.

Thanks,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center