Re: [PATCH 2/2] btrfs: Remove custom crc32c init code
From: Andy Shevchenko
Date: Fri Feb 02 2018 - 14:46:51 EST
On Mon, Jan 8, 2018 at 11:45 AM, Nikolay Borisov <nborisov@xxxxxxxx> wrote:
> The custom crc32 init code was introduced in
> 14a958e678cd ("Btrfs: fix btrfs boot when compiled as built-in") to
> enable using btrfs as a built-in. However, later as pointed out by
> 60efa5eb2e88 ("Btrfs: use late_initcall instead of module_init") this
> wasn't enough and finally btrfs was switched to late_initcall which
> comes after the generic crc32c implementation is initiliased. The
> latter commit superseeded the former. Now that we don't have to
> maintain our own code let's just remove it and switch to using the
> generic implementation.
> fs/btrfs/hash.c | 54 ----------------------------------------------
> fs/btrfs/hash.h | 43 ------------------------------------
IIRC Adding -D to git format-patch will make it shorter and nicer.
But please, double check that git am actually detects removals.
--
With Best Regards,
Andy Shevchenko