RE: [PATCH 1/1] scsi: ufs: make sure all interrupts are processed

From: Avri Altman
Date: Mon Feb 05 2018 - 07:57:33 EST




> >>> -----Original Message-----
> >>> From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi-
> >>> owner@xxxxxxxxxxxxxxx] On Behalf Of Asutosh Das
> >>> Sent: Tuesday, January 30, 2018 6:54 AM
> >>> To: subhashj@xxxxxxxxxxxxxx; cang@xxxxxxxxxxxxxx;
> >>> vivek.gautam@xxxxxxxxxxxxxx; rnayak@xxxxxxxxxxxxxx;
> >>> vinholikatti@xxxxxxxxx; jejb@xxxxxxxxxxxxxxxxxx;
> >>> martin.petersen@xxxxxxxxxx
> >>> Cc: linux-scsi@xxxxxxxxxxxxxxx; Venkat Gopalakrishnan
> >>> <venkatg@xxxxxxxxxxxxxx>; Asutosh Das <asutoshd@xxxxxxxxxxxxxx>;
> >>> open list <linux-kernel@xxxxxxxxxxxxxxx>
> >>> Subject: [PATCH 1/1] scsi: ufs: make sure all interrupts are
> >>> processed
> >>>
> >>> From: Venkat Gopalakrishnan <venkatg@xxxxxxxxxxxxxx>
> >>>
> >>> As multiple requests are submitted to the ufs host controller in
> >>> parallel there could be instances where the command completion
> >>> interrupt arrives later for a request that is already processed
> >>> earlier as the corresponding doorbell was cleared when handling the
> >>> previous interrupt. Read the interrupt status in a loop after
> >>> processing the received interrupt to catch such interrupts and
> >>> handle it.
> >>>
> >>> Signed-off-by: Venkat Gopalakrishnan <venkatg@xxxxxxxxxxxxxx>
> >>> Signed-off-by: Asutosh Das <asutoshd@xxxxxxxxxxxxxx>
Tested-by: avri.altman@xxxxxxx

Tested on kirin960 (mate9) and msm8998 (htc11), both where interrupt aggregation is not allowed.

As a side note, I noticed that this patch is part of several patches, fixing some qcom-staff.
Maybe you want to put them all in a patchset?

Thanks,
Avri