Re: [PATCH] nospec: Move array_index_nospec parameter checking into separate macro

[Dan Williams]

On Mon, Feb 5, 2018 at 6:16 AM, Will Deacon <will.deacon@xxxxxxx> wrote:
> For architectures providing their own implementation of
> array_index_mask_nospec in asm/barrier.h, attempting to use WARN_ONCE to
> complain about out-of-range parameters using WARN_ON results in a mess
> of mutually-dependent include files.
>
> Rather than unpick the dependencies, simply have the core code in nospec.h
> perform the checking for us.
>
> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Signed-off-by: Will Deacon <will.deacon@xxxxxxx>

Looks ok to me and produces the same assembly.

Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>