Re: [PATCH] nvme-pci: Fix incorrect use of CMB size to calculate q_depth

[Stephen Bates]

> On Feb 6, 2018, at 8:02 AM, Keith Busch <keith.busch@xxxxxxxxx> wrote:
> 
>> On Mon, Feb 05, 2018 at 03:32:23PM -0700, sbates@xxxxxxxxxxxx wrote:
>> 
>> -    if (dev->cmb && (dev->cmbsz & NVME_CMBSZ_SQS)) {
>> +    if (dev->cmb && use_cmb_sqes && (dev->cmbsz & NVME_CMBSZ_SQS)) {
> 
> Is this a prep patch for something coming later? dev->cmb is already
> NULL if use_cmb_sqes is false.

Thanks Keith. 

Not sure how I missed this. I was working on OOT patches to enable WDS and RDS in the CMB. I *thought* Iâd confirmed this patch was applicable to upstream. Looks like I did not do that correctly. 

Sorry for the churn. We can leave this patch out for now. Thanks for the prompt feedback everyone!

Stephen