Re: [PATCH 17/17] perf tools: Fix comment for sort__* compare functions

From: Arnaldo Carvalho de Melo
Date: Tue Feb 06 2018 - 14:25:13 EST

Next message: Trond Myklebust: "Re: It's back! (Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() ))"
Previous message: Arnaldo Carvalho de Melo: "Re: [PATCH 16/17] perf tests: Fix dwarf unwind for stripped binaries"
In reply to: Jiri Olsa: "[PATCH 17/17] perf tools: Fix comment for sort__* compare functions"
Next in thread: Jiri Olsa: "[PATCH 09/17] perf tools: Don't search for active kernel start in __machine__create_kernel_maps"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Em Tue, Feb 06, 2018 at 07:18:13PM +0100, Jiri Olsa escreveu:
> In commit 2f15bd8c6c6e ("perf tools: Fix "Command" sort_entry's cmp and collapse function")
> we switched from pointer to string comparison.
>
> But failed to remove related comments. Removing them and adding
> another one to warn before pointer comparison in here.

Applied.

Pushing perf/core out, please take a look at the others and rebase,

- Arnaldo

Next message: Trond Myklebust: "Re: It's back! (Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() ))"
Previous message: Arnaldo Carvalho de Melo: "Re: [PATCH 16/17] perf tests: Fix dwarf unwind for stripped binaries"
In reply to: Jiri Olsa: "[PATCH 17/17] perf tools: Fix comment for sort__* compare functions"
Next in thread: Jiri Olsa: "[PATCH 09/17] perf tools: Don't search for active kernel start in __machine__create_kernel_maps"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]