Re: [PATCH 20/20] x86/PCI: VMD: Fix malformed default

[Ulf Magnusson]

On Tue, Feb 6, 2018 at 8:11 PM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
>> x86/PCI: VMD: Fix malformed default
>
> In the title, please include a clue about what default you're talking
> about, e.g., mention Kconfig somehow.
>
> On Mon, Feb 05, 2018 at 02:21:32AM +0100, Ulf Magnusson wrote:
>> 'default N' should be 'default n', though they happen to have the same
>> effect here, due to undefined symbols (N in this case) evaluating to n
>> in a tristate sense.
>>
>> Remove the default from VMD instead of changing it. bool and tristate
>> symbols implicitly default to n.
>>
>> Discovered with the
>> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
>> script.
>>
>> Signed-off-by: Ulf Magnusson <ulfalizer@xxxxxxxxx>
>> ---
>>  drivers/pci/host/Kconfig | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
>> index a4ed7484d127..dc8a2a175f19 100644
>> --- a/drivers/pci/host/Kconfig
>> +++ b/drivers/pci/host/Kconfig
>> @@ -215,7 +215,6 @@ config PCIE_TANGO_SMP8759
>>  config VMD
>>       depends on PCI_MSI && X86_64 && SRCU
>>       tristate "Intel Volume Management Device Driver"
>> -     default N
>>       ---help---
>>         Adds support for the Intel Volume Management Device (VMD). VMD is a
>>         secondary PCI host bridge that allows PCI Express root ports,
>> --
>> 2.14.1
>>

Typoed the --in-reply-to. v2 is at https://lkml.org/lkml/2018/2/6/770

Cheers,
Ulf