Re: [PATCH 1/2] staging: android: ion: Remove dead code in ion_page_pool_free

[Laura Abbott]

On 02/06/2018 03:10 PM, Laura Abbott wrote:
> On 02/04/2018 07:26 PM, Yisheng Xie wrote:
> > ion_page_pool_add will always return 0, however ion_page_pool_free will
> > call ion_page_pool_free_pages when ion_page_pool_add's return value is
> > not 0, so it is a dead code which can be removed.
>
> Can you clean up ion_page_pool_add to be a void return as well?
> No sense in having it just always return 0.

Nevermind, just saw the follow up patch. Both of them:

Acked-by: Laura Abbott <labbott@xxxxxxxxxx>

> > Signed-off-by: Yisheng Xie <xieyisheng1@xxxxxxxxxx>
> > ---
> > Â drivers/staging/android/ion/ion_page_pool.c | 6 +-----
> > Â 1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c
> > index 4452e28..150626f 100644
> > --- a/drivers/staging/android/ion/ion_page_pool.c
> > +++ b/drivers/staging/android/ion/ion_page_pool.c
> > @@ -79,13 +79,9 @@ struct page *ion_page_pool_alloc(struct ion_page_pool *pool)
> > Â void ion_page_pool_free(struct ion_page_pool *pool, struct page *page)
> > Â {
> > -ÂÂÂ int ret;
> > -
> > ÂÂÂÂÂ BUG_ON(pool->order != compound_order(page));
> > -ÂÂÂ ret = ion_page_pool_add(pool, page);
> > -ÂÂÂ if (ret)
> > -ÂÂÂÂÂÂÂ ion_page_pool_free_pages(pool, page);
> > +ÂÂÂ ion_page_pool_add(pool, page);
> > Â }
> > Â static int ion_page_pool_total(struct ion_page_pool *pool, bool high)