Re: [PATCH v5 03/16] media: rkisp1: Add user space ABI definitions

[Hans Verkuil]

On 12/29/17 08:52, Shunqian Zheng wrote:
> From: Jeffy Chen <jeffy.chen@xxxxxxxxxxxxxx>
> 
> Add the header for userspace

General note: I saw four cases where this documentation referred to the
datasheet. Three comments on that:

1) You don't say which datasheet.
2) I assume the datasheet is under NDA?
3) You do need to give enough information so a reasonable default can be
   used. I mentioned in an earlier review that creating an initial params
   struct that can be used as a templete would be helpful (or even
   required), and that would be a good place to put such defaults.

Regards,

	Hans