Re: [PATCH] ACPI/IORT: Remove linker section for IORT entries again

[Jia He]

On 2/7/2018 7:41 PM, Lorenzo Pieralisi Wrote:
> On Tue, Feb 06, 2018 at 08:11:34PM -0800, Jia He wrote:
> > In commit 316ca8804ea8 ("ACPI/IORT: Remove linker section for IORT entries
> > probing"), iort entries was removed in vmlinux.lds.h. But in
> > commit 2fcc112af37f ("clocksource/drivers: Rename clksrc table to timer"),
> > this line was back incorrectly.
> >
> > It does no harm except for adding some useless symbols, so fix it.
> >
> > Signed-off-by: Jia He <hejianet@xxxxxxxxx>
forget to add another Signed-off-by line(because of my company's 
opensource rules)

Signed-off-by: Jia He <jia.he@xxxxxxxxxxxxxxxx>

> > ---
> >   include/asm-generic/vmlinux.lds.h | 1 -
> >   1 file changed, 1 deletion(-)
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
>
> Who is picking this up ?
Sorry, do you mean who is picking up acpi/iort subsystem?
I can't answer this question. I find this minor bug while doing the code 
review.

Cheers,
Jia
> > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> > index 1ab0e52..58b1dab 100644
> > --- a/include/asm-generic/vmlinux.lds.h
> > +++ b/include/asm-generic/vmlinux.lds.h
> > @@ -589,7 +589,6 @@
> >   	IRQCHIP_OF_MATCH_TABLE()					\
> >   	ACPI_PROBE_TABLE(irqchip)					\
> >   	ACPI_PROBE_TABLE(timer)						\
> > -	ACPI_PROBE_TABLE(iort)						\
> >   	EARLYCON_TABLE()
> >   
> >   #define INIT_TEXT							\
> > --
> > 2.7.4