Re: [PATCH] selftests/android: Fix line continuation in Makefile
From: Pintu Kumar
Date: Thu Feb 08 2018 - 00:15:24 EST
On Wed, Feb 7, 2018 at 10:46 PM, Daniel DÃaz RodrÃguez
<daniel.diaz@xxxxxxxxxx> wrote:
> Hello!
>
>
> On 7 February 2018 at 00:01, Pintu Kumar <pintu.ping@xxxxxxxxx> wrote:
> [...]
>> Thanks for your patch.
>> However, I have copied this Makefile from
>> tools/testing/selftests/futex/Makefile before modifying it.
>> If there is a problem with backslash then the same problem must be
>> there in futex Makefile as well.
>
> There is. Patch coming.
OK
>
>
> [...]
>> Also is it because of make version ?
>> Can you check your make version ?
>
> It's make 3.81.
My make version was 4.1.
So I did not face any problem. I guess this problem is fixed from make
version 4.x on wards.
However, for backward compatibility we can include these change.
So, its looks good for me, however someone else must approve it.
>
> Thanks and greetings!
>
> Daniel DÃaz
> daniel.diaz@xxxxxxxxxx