Re: [PATCH 3/5] USB: serial: f81232: enable remote wakeup via RX/RI pin

[Ji-Ze Hong (Peter Hong)]

Hi Johan,

Johan Hovold æ 2018/2/4 äå 09:46 åé:
> On Thu, Feb 01, 2018 at 11:13:01AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> > Our USB-To-Serial support RI/ RX remote wakeup by Modem, Fax or
> > other peripherals and we had tested it by following procedure with
> > device_set_wakeup_enable() enabled:
> >       1. Using pm-suspend to S3
> >       2. Trigger a pulse to RI/RX to wake up system.
> >
> > In our test, we can do remote wakeup only with
> > device_set_wakeup_enable() enabled.
>
> Yeah, but you need to enable it though sysfs. Not every device should be
> able to wake the system up. That's a decision left for user space.
>
> > Should we add device_set_wakeup_capable() & device_set_wakeup_enable()
> > like following link??
> > https://elixir.free-electrons.com/linux/latest/source/drivers/media/rc/mceusb.c#L1476
>
> No, your driver should not call device_set_wakeup_enable() itself. Just
> set the wakeup capable flag in probe. And if you can disable the wake up
> feature, this needs to be done at suspend depending on what user space
> has requested.

We'll change to device_set_wakeup_capable() and send the v2 patch when
test OK.

Thanks
--
With Best Regards,
Peter Hong