Re: [PATCH 01/20 v2] tracing: Add function based events

From: Steven Rostedt
Date: Thu Feb 08 2018 - 10:53:35 EST


On Thu, 8 Feb 2018 12:20:14 +0100
Jiri Olsa <jolsa@xxxxxxxxxx> wrote:

> On Wed, Feb 07, 2018 at 03:24:03PM -0500, Steven Rostedt wrote:
>
> SNIP
>
> > +
> > +void create_function_event_file(struct dentry *d_tracer)
> > +{
> > + struct dentry *d;
> > +
> > + d = trace_create_file("function_events", 0644, d_tracer, NULL,
> > + &func_event_fops);
> > + WARN(!d, "Failed to create function_events file");
> > +}
>
> this fucntion seems like leftover.. can't see any code using it
>

You are right. My original version had it created via instance, but
then I realized that the events are for all instances. I'll nuke this.

Thanks!

-- Steve