Re: [PATCH] cramfs: better MTD dependency expression

From: Randy Dunlap
Date: Thu Feb 08 2018 - 15:01:57 EST


On 02/08/2018 11:38 AM, Linus Torvalds wrote:
> On Wed, Feb 7, 2018 at 7:08 PM, Nicolas Pitre <nicolas.pitre@xxxxxxxxxx> wrote:
>>
>> Viro once told me that my cramfs pull requests could go either to him or
>> to you. I have only this one patch at the moment, and since it depends
>> on a commit that recently appeared in your tree I'm therefore sending it
>> directly to you.
>
> Applied.
>
> Although I'm not entirely convinced that the simpler dependency is
> easier to _read_ and understand.
>
> It is clearly simpler, though.
>
> Linus
>


There was some pushback on the patch, mostly from Arnd.

I think we agree that it's not easier to read/understand, but Nicolas
is the maintainer... and he patched kconfig so that this would work.
kconfig did need fixing in that respect -- it was supposed to work
but didn't.

(That was commit 9059a3493efea6492451430c7e2fa0af799a2abb:
kconfig: fix relational operators for bool and tristate symbols)

--
~Randy