Re: [PATCH 1/2] zsmalloc: introduce zs_huge_object() function

From: Sergey Senozhatsky
Date: Fri Feb 09 2018 - 00:05:03 EST


On (02/08/18 20:10), Matthew Wilcox wrote:
> > > > +/*
> > > > + * Check if the object's size falls into huge_class area. We must take
> > > > + * ZS_HANDLE_SIZE into account and test the actual size we are going to
> > > > + * use up. zs_malloc() unconditionally adds handle size before it performs
> > > > + * size_class lookup, so we may endup in a huge class yet zs_huge_object()
> > > > + * returned 'false'.
> > > > + */
> > >
> > > Can you please reformat this comment as kernel-doc?
> >
> > Is this - Documentation/doc-guide/kernel-doc.rst - the right thing
> > to use as a reference?
>
> Yes. I just sent a revision to it that makes it (I think) a little
> easier to read. Try this version:

That's helpful, thanks! Will take a look and re-spin the patch.

-ss