Re: [PATCH v7 1/7] livepatch: Use lists to manage patches, objects and functions

From: Miroslav Benes
Date: Fri Feb 09 2018 - 05:06:28 EST


On Tue, 6 Feb 2018, Petr Mladek wrote:

> From: Jason Baron <jbaron@xxxxxxxxxx>
>
> Currently klp_patch contains a pointer to a statically allocated array of
> struct klp_object and struct klp_objects contains a pointer to a statically
> allocated array of klp_func. In order to allow for the dynamic allocation
> of objects and functions, link klp_patch, klp_object, and klp_func together
> via linked lists. This allows us to more easily allocate new objects and
> functions, while having the iterator be a simple linked list walk.
>
> The static structures are added to the lists early. It allows to add
> the dynamically allocated objects before klp_init_object() and
> klp_init_func() calls. Therefore it reduces the further changes
> to the code.
>
> Also klp_init_*_list() functions are split because they will
> be used when adding the dynamically allocated structures.
>
> This patch does not change the existing behavior.
>
> Signed-off-by: Jason Baron <jbaron@xxxxxxxxxx>
> [pmladek@xxxxxxxx: Initialize lists before init calls]
> Signed-off-by: Petr Mladek <pmladek@xxxxxxxx>
> Cc: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> Cc: Jessica Yu <jeyu@xxxxxxxxxx>
> Cc: Jiri Kosina <jikos@xxxxxxxxxx>
> Cc: Miroslav Benes <mbenes@xxxxxxx>

Acked-by: Miroslav Benes <mbenes@xxxxxxx>

Miroslav