Re: [PATCH 1/2] acpi/dptf: document sysfs atttributes

[Rafael J. Wysocki]

On Fri, Feb 9, 2018 at 11:54 AM, Aishwarya Pant <aishpant@xxxxxxxxx> wrote:
> On Fri, Feb 09, 2018 at 11:31:35AM +0100, Rafael J. Wysocki wrote:
>> On Wed, Feb 7, 2018 at 2:18 PM, Aishwarya Pant <aishpant@xxxxxxxxx> wrote:
>> > The descriptions have been collected from git commit logs and reading
>> > through code.
>> >
>> > Signed-off-by: Aishwarya Pant <aishpant@xxxxxxxxx>
>> > ---
>> >  Documentation/ABI/testing/sysfs-platform-dptf | 30 +++++++++++++++++++++++++++
>> >  1 file changed, 30 insertions(+)
>> >  create mode 100644 Documentation/ABI/testing/sysfs-platform-dptf
>> >
>> > diff --git a/Documentation/ABI/testing/sysfs-platform-dptf b/Documentation/ABI/testing/sysfs-platform-dptf
>> > new file mode 100644
>> > index 000000000000..e8168e5198d7
>> > --- /dev/null
>> > +++ b/Documentation/ABI/testing/sysfs-platform-dptf
>> > @@ -0,0 +1,30 @@
>> > +sysfs interface for ACPI DPTF platform power driver
>> > +---------------------------------------------------
>>
>> The header isn't necessary.
>>
>> > +
>> > +What:          /sys/bus/platform/devices/INT3407:00/dptf_power/charger_type
>> > +What:          /sys/bus/platform/devices/INT3407:00/dptf_power/adapter_rating_mw
>> > +What:          /sys/bus/platform/devices/INT3407:00/dptf_power/max_platform_power_mw
>> > +What:          /sys/bus/platform/devices/INT3407:00/dptf_power/platform_power_source
>> > +What:          /sys/bus/platform/devices/INT3407:00/dptf_power/battery_steady_power
>>
>> There should be one entry per attribute AFAICS.
>
> I grouped attributes by the date in which they were added for brevity, because
> otherwise fields like Date added, KernelVersion and Contact information are the
> same.
>
> I can split them up if it makes more sense...

That's what the format is from looking at the existing files.