Re: net: thunder: change q_len's type to handle max ring size

From: Dean Nelson
Date: Fri Feb 09 2018 - 07:52:07 EST


On 02/08/2018 10:29 PM, Sunil Kovvuri wrote:
On Fri, Feb 9, 2018 at 3:27 AM, Dean Nelson <dnelson@xxxxxxxxxx> wrote:
On 02/08/2018 02:34 PM, David Miller wrote:

From: Dean Nelson <dnelson@xxxxxxxxxx>
Date:

The Cavium thunder nicvf driver supports rx/tx rings of up to 65536
entries per.
...

Another way to solve this could have been to encode that length
as "length - 1"


True. I had pondered that, but felt that since changing q_len's type
didn't add any length to the structure and that it was less impactful
from a number-of-lines of code changed perspective, I'd opt for this
route.

Cavium, if you'd prefer this goes the route that Dave just mentioned,
please let me know and I can make a new patch against what's been
applied?

Thanks for fixing this and i think the current patch is fine.

You're welcome. And thanks for responding. So I'll leave things as they
are.