Re: Regression after commit 19809c2da28a ("mm, vmalloc: use __GFP_HIGHMEM implicitly")

From: Matthew Wilcox
Date: Fri Feb 09 2018 - 09:07:36 EST


On Fri, Feb 09, 2018 at 05:12:56PM +0800, Kai Heng Feng wrote:
> Hi Matthew,
>
> > On Feb 9, 2018, at 12:08 PM, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
> > Alternatively, try this. It passes in GFP_DMA32 from vmalloc_32,
> > regardless of whether ZONE_DMA32 exists or not. If ZONE_DMA32 doesn't
> > exist, then we clear it in __vmalloc_area_node(), after using it to
> > determine that we shouldn't set __GFP_HIGHMEM.
>
> IIUC, I need to let drivers/media drivers start using vmalloc_32() with your
> patch, right?

Hopefully those that need to already are. Otherwise they're broken
on 64-bit. I do see several places already using vmalloc_32().