Re: scripts/coccinelle/misc/shift.cocci: Refactoring?

From: SF Markus Elfring
Date: Fri Feb 09 2018 - 09:10:52 EST

Next message: Greg Kroah-Hartman: "[PATCH 4.9 40/92] x86/cpufeatures: Add Intel feature bits for Speculation Control"
Previous message: Greg Kroah-Hartman: "[PATCH 4.9 42/92] x86/msr: Add definitions for new speculation control MSRs"
In reply to: Dan Carpenter: "Re: [PATCH] scripts/coccinelle/misc/shift.cocci: detect < or > that should be a shift"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> +|
> +WARN_ON(x op@p y)
> +|
> +WARN_ON_ONCE(x op@p y)
> +|

Can it be nice to work with nested SmPL disjunctions so that a bit of
duplicate SmPL code will be reduced?

> +coccilib.org.print_todo(j0[0], msg)

Will it be nicer to pass a string literal instead of a variable for the message
as a method parameter?

Regards,
Markus

Next message: Greg Kroah-Hartman: "[PATCH 4.9 40/92] x86/cpufeatures: Add Intel feature bits for Speculation Control"
Previous message: Greg Kroah-Hartman: "[PATCH 4.9 42/92] x86/msr: Add definitions for new speculation control MSRs"
In reply to: Dan Carpenter: "Re: [PATCH] scripts/coccinelle/misc/shift.cocci: detect < or > that should be a shift"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]