Re: [PATCH RFC tip/lkmm 04/10] EXP litmus_tests: Add comments explaining tests' purposes

From: Paul E. McKenney
Date: Fri Feb 09 2018 - 20:05:04 EST


On Fri, Feb 09, 2018 at 01:46:30PM -0500, Alan Stern wrote:
> On Fri, 9 Feb 2018, Paul E. McKenney wrote:
>
> > This commit adds comments to the litmus tests summarizing what these
> > tests are intended to demonstrate.
> >
> > Suggested-by: Ingo Molnar <mingo@xxxxxxxxxx>
> > Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> > [ paulmck: Apply Andrea's and Alan's feedback. ]
> > ---
>
> > --- a/tools/memory-model/litmus-tests/IRIW+poonceonces+OnceOnce.litmus
> > +++ b/tools/memory-model/litmus-tests/IRIW+poonceonces+OnceOnce.litmus
> > @@ -1,5 +1,15 @@
> > C IRIW+poonceonces+OnceOnce
> >
> > +(*
> > + * Result: Never
> > + *
> > + * Test of independent reads from independent writes with nothing
> > + * between each pairs of reads. In other words, is anything at all
> > + * needed to cause two different reading processes to agree on the order
> > + * of a pair of writes, where each write is to a different variable by a
> > + * different process?
> > + *)
>
> The result should be Sometimes.

Right you are, and better yet, the memory model agrees with you.

I have fixed this, thank you for the careful review!

Thanx, Paul