Re: [PATCH] watchdog: coh901327: make license text and module licence match

From: Philippe Ombredanne
Date: Sat Feb 10 2018 - 09:54:07 EST


On Sat, Feb 10, 2018 at 10:27 AM, Marcus Folkesson
<marcus.folkesson@xxxxxxxxx> wrote:
> Licence text is specifying "GPLv2" but the MODULE_LICENSE is set to "GPLv2
> or later".
>
> See include/linux/module.h:
> "GPL" [GNU Public License v2 or later]
> "GPL v2" [GNU Public License v2]
>
> When on it, add SPDX identifier tag.
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@xxxxxxxxx>
> ---
> drivers/watchdog/coh901327_wdt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/coh901327_wdt.c b/drivers/watchdog/coh901327_wdt.c
> index 5d8eb9a30879..7b71e0a3e6cc 100644
> --- a/drivers/watchdog/coh901327_wdt.c
> +++ b/drivers/watchdog/coh901327_wdt.c
> @@ -1,8 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * coh901327_wdt.c
> *
> * Copyright (C) 2008-2009 ST-Ericsson AB
> - * License terms: GNU General Public License (GPL) version 2
> * Watchdog driver for the ST-Ericsson AB COH 901 327 IP core
> * Author: Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>
> */
> @@ -420,5 +420,5 @@ MODULE_DESCRIPTION("COH 901 327 Watchdog");
> module_param(margin, uint, 0);
> MODULE_PARM_DESC(margin, "Watchdog margin in seconds (default 60s)");
>
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
> MODULE_ALIAS("platform:coh901327-watchdog");

Thank you!

Reviewed-by: Philippe Ombredanne <pombredanne@xxxxxxxx>

--
Cordially
Philippe Ombredanne