Re: [PATCH] x86/Kconfig: Further simplify the NR_CPUS config

[Randy Dunlap]

On 02/10/2018 02:19 PM, Linus Torvalds wrote:
> Looks good to me.
> 
> At the risk of bike-shedding, we could remove all the
> 
>         default    1 if !SMP
> 
> from the BEGIN/END/DEFAULT things, and perhaps just keep that part in NR_CPUS.
> 
> I didn't check, but I *think* it would work to just do
> 
>  config NR_CPUS
>         int "Maximum number of CPUs" if SMP && !MAXSMP
>         range NR_CPUS_RANGE_BEGIN NR_CPUS_RANGE_END
>         default "1" if !SMP
>         default NR_CPUS_DEFAULT
> 
> but maybe the "range" line would need an "if !SMP" on it too to avoid
> the issue with "1" being out of range.,

Yeah, I had an early test that failed due to something like that.


-- 
~Randy