Re: [PATCH] arm64: Enable SPRD_TIMER

From: Chunyan Zhang
Date: Sun Feb 11 2018 - 06:41:58 EST


Hi Baolin,

On 7 February 2018 at 11:12, Baolin Wang <baolin.wang@xxxxxxxxxx> wrote:
> On 7 February 2018 at 10:31, Chunyan Zhang <zhang.lyra@xxxxxxxxx> wrote:
>> Hi Baolin,
>>
>> On 6 February 2018 at 18:36, Baolin Wang <baolin.wang@xxxxxxxxxx> wrote:
>>> Enable Spreadtrum timer driver for Spreadtrum plaform, which will be used
>>> as tick broadcast device.
>>>
>>> Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxx>
>>> ---
>>> arch/arm64/Kconfig.platforms | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
>>> index fbedbd8..3e0bbb0 100644
>>> --- a/arch/arm64/Kconfig.platforms
>>> +++ b/arch/arm64/Kconfig.platforms
>>> @@ -224,6 +224,7 @@ config ARCH_TEGRA
>>>
>>> config ARCH_SPRD
>>> bool "Spreadtrum SoC platform"
>>> + select SPRD_TIMER
>>
>> Do we have to select SPRD_TIMER here? SC9836, SC9860 have been working
>> with a minimum system without SPRD TIMER.
>
> Yes, we need register this timer as the tick broadcast device,
> otherwise we will use one hrtimer to be registered the broadcast
> device, which will affect the No-Hz of CPU attaching the
> broadcast-hrtimer.

Again, Spreadtrum's two boards - SC9836/SC9860 - can run into console
without SPRD_TIMER, we can also debug some kernel origianl feature or
some basic drivers on these two boards, such as CoreSight, clock
driver, etc.

In my opinion we should keep the kernel as simple as possible, the
above information can go to the 'help' graph of SPRD_TIMER in its
Kconfig.

Thanks,
Chunyan

>
> --
> Baolin.wang
> Best Regards