Re: [PATCH 8/8] ASoC: samsung,tm2-audio DT binding documentation update

From: Krzysztof Kozlowski
Date: Mon Feb 12 2018 - 04:19:40 EST


On Wed, Feb 7, 2018 at 5:31 PM, Sylwester Nawrocki
<s.nawrocki@xxxxxxxxxxx> wrote:
> On 02/06/2018 02:05 PM, Krzysztof Kozlowski wrote:
>> On Mon, Feb 5, 2018 at 4:44 PM, Sylwester Nawrocki
>> <s.nawrocki@xxxxxxxxxxx> wrote:
>>> This patch documents additional entries of the audio-codec and
>>> i2s-controller properties required for the HDMI audio support.
>>>
>>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
>>> ---
>>> .../devicetree/bindings/sound/samsung,tm2-audio.txt | 14 +++++++++-----
>>> 1 file changed, 9 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt b/Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt
>>> index 94442e5673b3..f5ccc12ddc00 100644
>>> --- a/Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt
>>> +++ b/Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt
>>> @@ -4,9 +4,13 @@ Required properties:
>>>
>>> - compatible : "samsung,tm2-audio"
>>> - model : the user-visible name of this sound complex
>>> - - audio-codec : the phandle of the wm5110 audio codec node,
>>> - as described in ../mfd/arizona.txt
>>> - - i2s-controller : the phandle of the I2S controller
>>> + - audio-codec : the first entry should be phandle of the wm5110 audio
>>> + codec node, as described in ../mfd/arizona.txt;
>>> + the second entry should be phandle of the HDMI
>>
>> AFAIU, this property is still optional so the wording should be
>> different. Maybe just add "optional properties" paragraph?
>
> I'd like to keep the second entries required in the documentation,
> and the driver would still be handling the case with just single
> entries.

I understand.
Acked-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Best regards,
Krzysztof