Re: [RFC PATCH] soc: zynqmp: Add support for tap delay settings

[Philippe Ombredanne]

On Mon, Feb 12, 2018 at 11:35 AM, Manish Narani
<manish.narani@xxxxxxxxxx> wrote:
> This patch add support for tep delays programming for zynqmp platform.
> This also adds dll reset support.
>
> Signed-off-by: Manish Narani <mnarani@xxxxxxxxxx>

<snip>

> --- /dev/null
> +++ b/drivers/soc/xilinx/zynqmp/tap_delays.c
> @@ -0,0 +1,270 @@
> +/*
> + * Xilinx Zynq MPSoC Tap Delay Programming
> + *
> + *  Copyright (C) 2016 Xilinx, Inc.
> + *
> + * This program is free software: you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation, either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program.  If not, see <http://www.gnu.org/licenses/>.
> + */

Dear Manish,
Why not using the SPDX ids there too and elsewhere? You are using them
alright in many other places in this patch. See
Documentation/process/license-rules.rst for details
-- 
Cordially
Philippe Ombredanne