Re: [PATCH] MAINTAINERS: add Freescale pin controllers

[Lucas Stach]

Am Montag, den 12.02.2018, 13:22 +0200 schrieb Baruch Siach:
> Hi Lucas,
> 
> On Mon, Feb 12, 2018 at 11:48:22AM +0100, Lucas Stach wrote:
> > Am Samstag, den 10.02.2018, 16:32 +0100 schrieb Stefan Agner:
> > > Add Dong Aisheng, Fabio Estevam, Shawn Guo and myself as
> > > maintainer
> > > and Sascha as reviewer.
> > > 
> > > Signed-off-by: Stefan Agner <stefan@xxxxxxxx>
> > > ---
> > > ÂMAINTAINERS | 11 +++++++++++
> > > Â1 file changed, 11 insertions(+)
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 82ad0eabce4f..fb672dfc519d 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -10768,6 +10768,17 @@ L:	linux-gpio@xxxxxxxxxxxxxxx
> > > ÂS:	Supported
> > > ÂF:	drivers/pinctrl/pinctrl-at91-pio4.*
> > > Â
> > > +PIN CONTROLLER - FREESCALE
> > > +M:	Dong Aisheng <aisheng.dong@xxxxxxx>
> > > +M:	Fabio Estevam <festevam@xxxxxxxxx>
> > > +M:	Shawn Guo <shawnguo@xxxxxxxxxx>
> > > +M:	Stefan Agner <stefan@xxxxxxxx>
> > > +R:	Sascha Hauer <kernel@xxxxxxxxxxxxxx>
> > 
> > I'm fine with the patch, but it might make sense to clarify this a
> > bit:
> > the kernel@ address is really the whole Pengutronix kernel team,
> > not
> > just Sascha. Using this address is totally fine if you expect
> > comments
> > on patches, as it gives them a quite wide exposure inside of PTX.
> 
> Of the 5 mentions of kernel@xxxxxxxxxxxxxx in MAINTAINERS as of
> v4.16-rc1,Â
> three name Sascha, and two name Uwe. Would you like to also clarify
> those?

I think it fine to keep the names of the individual people where they
maintain stuff, as this is usually bound to a single person (where
kernel@ address is only used for the exposure benefits), but I think it
makes less sense for the reviewer role.

Regards,
Lucas