Re: [PATCH] net: phy: fix wrong mask to phy_modify()

From: Andrew Lunn
Date: Mon Feb 12 2018 - 08:40:00 EST


On Mon, Feb 12, 2018 at 12:02:52PM +0100, Ingo van Lil wrote:
> When forcing a specific link mode, the PHY driver must clear the
> existing speed and duplex bits in BMCR while preserving some other
> control bits. This logic was accidentally inverted with the introduction
> of phy_modify().
>
> Signed-off-by: Ingo van Lil <inguin@xxxxxx>

Fixes: fea23fb591cc ("net: phy: convert read-modify-write to phy_modify()")
Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew