Re: [PATCH v2 01/12] ARM: dts: STi: Fix bindings notation
From: Rob Herring
Date: Mon Feb 12 2018 - 10:20:03 EST
On Mon, Feb 12, 2018 at 8:42 AM, <patrice.chotard@xxxxxx> wrote:
> From: Patrice Chotard <patrice.chotard@xxxxxx>
>
> Remove leading 0x and 0s from bindings notation
> Add missing unit-address and remove some which are useless.
>
> This allows to fix several warnings like :
>
> Warning (unit_address_vs_reg): Node XXXX has a reg or ranges property, but no unit name
> Warning (simple_bus_reg): Node XXXX simple-bus unit address format error, expected "123456"
> Warning (unit_address_vs_reg): Node XXXX has a unit name, but no reg property
>
> Signed-off-by: Patrice Chotard <patrice.chotard@xxxxxx>
> ---
[...]
> diff --git a/arch/arm/boot/dts/stih407-pinctrl.dtsi b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> index a29090077fdf..53c6888d1fc0 100644
> --- a/arch/arm/boot/dts/stih407-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> @@ -45,7 +45,7 @@
> };
>
> soc {
> - pin-controller-sbc {
> + pin-controller-sbc@961f080 {
While you're here changing the node name, these all should be "pinctrl@..."
With that,
Reviewed-by: Rob Herring <robh@xxxxxxxxxx>