Re: [PATCH 4/6] Protectable Memory
From: Mike Rapoport
Date: Mon Feb 12 2018 - 10:32:17 EST
On Mon, Feb 12, 2018 at 03:41:57PM +0200, Igor Stoppa wrote:
>
>
> On 12/02/18 14:53, Mike Rapoport wrote:
> > 'scripts/kernel-doc -v -none
>
> That has a quite interesting behavior.
>
> I run it on genalloc.c while I am in the process of adding the brackets
> to the function names in the kernel-doc description.
>
> The brackets confuse the script and it fails to output the name of the
> function in the log:
>
> lib/genalloc.c:123: info: Scanning doc for get_bitmap_entry
> lib/genalloc.c:139: info: Scanning doc for
> lib/genalloc.c:152: info: Scanning doc for
> lib/genalloc.c:164: info: Scanning doc for
>
> The first function does not have the brackets.
> The others do. So what should I do with the missing brackets?
> Add them, according to the kernel docs, or leave them out?
Seems that kernel-doc does not consider () as a valid match for the
identifier :)
Can you please check with the below patch?
> I'd lean toward adding them.
>
> --
> igor
--
Sincerely yours,
Mike.