Re: [PATCH] mtd: nand: MTD_NAND_MARVELL should depend on HAS_DMA

From: Boris Brezillon
Date: Mon Feb 12 2018 - 16:22:25 EST


On Tue, 30 Jan 2018 14:23:21 +0100
Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:

> If NO_DMA=y:
>
> ERROR: "bad_dma_ops" [drivers/mtd/nand/marvell_nand.ko] undefined!
>
> Add a dependency on HAS_DMA to fix this.

Applied.

Thanks,

Boris

>
> Fixes: 02f26ecf8c772751 ("mtd: nand: add reworked Marvell NAND controller driver")
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> ---
> drivers/mtd/nand/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index e6b8c59f2c0da7c0..736ac887303c88ba 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -328,7 +328,7 @@ config MTD_NAND_MARVELL
> tristate "NAND controller support on Marvell boards"
> depends on PXA3xx || ARCH_MMP || PLAT_ORION || ARCH_MVEBU || \
> COMPILE_TEST
> - depends on HAS_IOMEM
> + depends on HAS_IOMEM && HAS_DMA
> help
> This enables the NAND flash controller driver for Marvell boards,
> including:



--
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com