Re: [PATCH v9 2/3] arm: dts: add Nuvoton NPCM750 device tree
From: Avi Fishman
Date: Tue Feb 13 2018 - 04:33:04 EST
On Tue, Feb 13, 2018 at 10:30 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Tue, Feb 6, 2018 at 12:57 AM, Brendan Higgins
> <brendanhiggins@xxxxxxxxxx> wrote:
>> Add a common device tree for all Nuvoton NPCM750 BMCs and a board
>> specific device tree for the NPCM750 (Poleg) evaluation board.
>>
>> Signed-off-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
>> Reviewed-by: Tomer Maimon <tmaimon77@xxxxxxxxx>
>> Reviewed-by: Avi Fishman <avifishman70@xxxxxxxxx>
>> Reviewed-by: Joel Stanley <joel@xxxxxxxxx>
>> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
>> Tested-by: Tomer Maimon <tmaimon77@xxxxxxxxx>
>> Tested-by: Avi Fishman <avifishman70@xxxxxxxxx>
> ...
>> + enable-method = "nuvoton,npcm7xx-smp";
>
> I see this has already been reviewed quite a bit, but I'm curious
> about the 'npcm7xx'
> part here. Shouldn't that be a real chip name rather than a wildcard?
>
> Arnd
There is a family of npcm7xx, some with SMP and some without.
For those who has it, it is common for all to use the same
"nuvoton,npcm7xx-smp".
Avi