Re: [PATCH 2/3] arm64: dts: rockchip: add cdn-dp node for rk3399.

[Heiko Stübner]

Hi Enric,

Am Dienstag, 13. Februar 2018, 12:36:47 CET schrieb Enric Balletbo Serra:
> 2018-02-13 11:42 GMT+01:00 Enric Balletbo i Serra
> 
> <enric.balletbo@xxxxxxxxxxxxx>:
> > Hi Heiko,
> > 
> > On 10/02/18 17:16, Heiko Stuebner wrote:
> >> Hi Enric,
> >> 
> >> Am Mittwoch, 7. Februar 2018, 17:31:49 CET schrieb Enric Balletbo i 
Serra:
> >>> From: Chris Zhong <zyw@xxxxxxxxxxxxxx>
> >>> 
> >>> Add a node for the cdn DP controller which is embedded in the rk3399
> >>> SoC.
> >>> 
> >>> Signed-off-by: Chris Zhong <zyw@xxxxxxxxxxxxxx>
> >>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
> >>> ---
> >>> 
> >>>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 50
> >>>  ++++++++++++++++++++++++++++++++>> 
> >> It looks like there is no binding document at all for cdn-dp? At least
> >> I couldn't find one and the original series also didn't seem to include
> >> one.
> >> 
> >> And while I don't see anything problematic right with the used properties
> >> right now, I'd think we should really have a binding and give
> >> dt-maintainers a chance to complain, before adding devicetree nodes
> >> based on it.
> >> 
> >> I'd guess a mostly usable binding doc should already sit in the chromeos
> >> tree, which you could base a v2 of this series on?
> > 
> > Sure, I'll send a v2 for this series. Thanks.
> > 
> >   Enric
> 
> So seems that the binding was already discussed and accepted here [1]
> but for some reason never landed. So I think that I'll send v2 just
> including the binding patch so all can land together. Sounds good?
> 
> [1] https://patchwork.kernel.org/patch/9278077/

Nice find and yep, just resending binding + your patches 2+3
is enough then :-)


Heiko