Re: [PATCH] ASoC: codecs: Add support for AK4458 DAC driver

[Mark Brown]

On Tue, Feb 13, 2018 at 09:22:24AM +0000, Cosmin Samoila wrote:

> This is used to set the codec in Manual Setting Mode, meaning that
> the default sampling speed is set based on DFS0 and DFS1 bits. In
> Auto Setting Mode, the MCLK frequency is detected automatically and
> DFS bits are ignored.

But why is it a compile time option?

> This compile time option is used to know when to set the ACKS bit in
> init_reg function that switches between modes.
> At this moment we are only using Auto Mode and I can remove it if
> you think is not necessary.

Yes, just remove it - if there needs to be some control it should
probably be done by the machine driver, or through DT.

Attachment: signature.asc
Description: PGP signature